feat(server): Track outcome source #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finish integration tests
The macro is improved to support pattern destructuring in addition to literal parameters. Also, the examples were too artificial, and there was really no reason they should fail to compile. On top of that, they had syntax errors, which are fixed now.
Refactors `relay-quotas` without any functional changes and adds a few tests.
According to our dev docs at https://develop.sentry.dev/sdk/event-payloads/span/, status should be an explicit field on the span struct. The JS SDK is already setting it, and it is rendered for individual spans in the UI. Update the Span struct to have a field status. This is typed using SpanStatus, the same as the status on an event. Also updated the tests in the file.
jan-auer
changed the title
jan-auer
reviewed
Jun 5, 2020
untitaker
approved these changes
Jun 5, 2020
jan-auer
reviewed
Jun 9, 2020
jan-auer
requested changes
Jun 9, 2020
Co-authored-by: Jan Michael Auer <jan.auer@sentry.io>
jan-auer
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track which relay generated each outcome