Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): Add ability to add global tags to all metrics #625

Merged
merged 4 commits into from
Jun 15, 2020
Merged

feat(metrics): Add ability to add global tags to all metrics #625

merged 4 commits into from
Jun 15, 2020

Conversation

untitaker
Copy link
Member

  • Add option for hardcoded set of tags for all metrics
  • Add option to attach current hostname to all metrics

@untitaker untitaker requested review from tonyo, jan-auer and a team June 15, 2020 09:16
tonyo
tonyo approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@tonyo tonyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

jan-auer
jan-auer approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few nitpicks below. Please also add a changelog line to "Features".

On the side, this will need an update in src\metrics.rs.

relay-common/src/metrics.rs Show resolved Hide resolved
relay-common/src/metrics.rs Outdated Show resolved Hide resolved
relay-config/Cargo.toml Outdated Show resolved Hide resolved
src/setup.rs Outdated Show resolved Hide resolved
@jan-auer
Copy link
Member

@untitaker Can you please trigger another build of this in Travis? Once this is green, we can merge.

@untitaker untitaker merged commit 37a600d into master Jun 15, 2020
@untitaker untitaker deleted the feat/metrics-global-tags branch June 15, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyo tonyo tonyo approved these changes

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@untitaker @jan-auer @tonyo