feat(server): Apply quotas per item #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
force-pushed
the
feat/item-quotas
branch
from
fd6a970
to
e66739c
Compare
jan-auer
force-pushed
the
feat/item-quotas
branch
from
e66739c
to
a85ab7e
Compare
|
This is ready now. |
untitaker
approved these changes
Jun 26, 2020
untitaker
reviewed
Jun 26, 2020
| # TODO: There are no outcomes emitted for attachments yet. Instead, sleep to allow Relay to | ||
| # process the event and cache the rate limit | ||
| # outcomes_consumer.assert_rate_limited("static_disabled_quota") | ||
| time.sleep(0.2) |
There was a problem hiding this comment.
Oh that is too short for sure.
There was a problem hiding this comment.
I'm hoping to get rid of this very soon. The TODO above is related to this -- we need to wait for outcomes eventually.
Right now, it seems that 200ms is enough for this particular test. If it turns out that this is flakey, we can increase it.
jan-auer
added a commit
that referenced
this pull request
Jul 2, 2020
* master: fix(server): Do not 429 for event-only attachments (#647) doc(config): Remove references to advanced data scrubbing (#648) fix(server): Never respond with 429 for minidumps (#646) docs(config): Update relay end user documentation (#641) license: Update BSL change date fix: Add missing .NET 4.8 patches (#642) feat(server): Emit attachment sizes to Kafka (#644) fix(store): Use clock drift normalizer to correct all timestamp issues (#634) feat(server): Emit flags for rate limited attachments (#640) feat(server): Enforce attachment size in rate limits (#639) feat(server): Apply quotas per item (#636)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invokes the rate limiter with correct data categories for all items in the envelope, sharing the same code as the rate limiting fast path.
Based on #635