fix(danger): Comment only on missing changelogs #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
approved these changes
Aug 19, 2020
|
Updating once more after talking to @untitaker: We comment only if the changelog is missing explicitly, otherwise we're silent to avoid unnecessary notifications. |
jan-auer
changed the title
jan-auer
added a commit
that referenced
this pull request
Aug 26, 2020
* master: build(workspace): Move relay binary to workspace crate (#733) fix: Fix data schemas github action (#730) fix(docs): Incorrect init command in README (#732) fix(getting-started): Fix documentation links to other pages (#729) feat(server): Add initial minidump scrubbing (#682) fix: Remove jsonschema docs (#727) fix(docs): Fix a broken link test(server): Add unit tests to tracked future (#725) feat(server): Support chunked formdata for Crashpad (#721) fix(danger): Comment only on missing changelogs (#723) test: Require any python3 and support python3.8 (#722) fix: Re-add pii=maybe to span databags (#720) fix(schema): Type out span data and tags (#713)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our danger bot comments with a skip message even if there is a valid changelog, for instance in #721 (comment).
#skip-changelog