fix: Avoid rust-analyzer recursion bug #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Aug 27, 2020
untitaker
reviewed
Aug 27, 2020
| @@ -16,8 +16,10 @@ use crate::protocol::{AsPair, IpAddr, NativeImagePath, PairList, User}; | |||
| use crate::types::{Meta, ProcessingAction, ProcessingResult, Remark, RemarkType}; | |||
|
|
|||
| lazy_static! { | |||
| static ref NULL_SPLIT_RE: Regex = #[allow(clippy::trivial_regex)] | |||
| Regex::new("\x00").unwrap(); | |||
| static ref NULL_SPLIT_RE: Regex = { | |||
There was a problem hiding this comment.
can we add a code comment here if we're going to merge this. it's not obvious why formatting matters here and it's easy to regress when updating rustfmt
There was a problem hiding this comment.
This is even invalid syntax in Rust. Without lazy_static, this would not compile as statement and expression attributes aren't stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute alone triggers a parsing error which leads to an endless loop or recursion in Rust Analyzer.
#skip-changelog