feat: Scrub filenames in the minidump modules list #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ValueType::Filepath is added and replaces NativeDebugImage, it identifies a value which is a string containing a pathname. This is then used when scrubbing pathnames in the minidump module list.
flub
commented
Sep 23, 2020
flub
commented
Sep 23, 2020
flub
commented
Sep 23, 2020
untitaker
requested changes
Sep 23, 2020
flub
commented
Sep 23, 2020
Previously they were not being scrubbed.
This uses the endian indicator in the minidump to achieve this. It does introduce a dependency on scroll directly as the minidump crate does not expose the type otherwise. We use the same version as the minidump crate does.
This only tests a windows minidump so far.
jan-auer
reviewed
Sep 25, 2020
added 5 commits
September 25, 2020 14:25
Writing tests with this is slightly nicer.
This primarily implements the DoubleEndedIterator to WStrChars and WStrCharIndices. It also introduces two new helpers: for constructing a u16 from 2 bytes and for constructing a char from two u16s. Finally it optimises the Iter::count and Iter::last implementations of the char iters.
This was not worth the time spent on it, but was fun.
untitaker
approved these changes
Sep 25, 2020
added 2 commits
September 25, 2020 16:23
They were applying some pii config to the minidump, but the test was checking the attachment (the minidump) was not being modified.
jan-auer
approved these changes
Sep 28, 2020
jan-auer
added a commit
that referenced
this pull request
Sep 29, 2020
* master: feat: Scrub filenames in the minidump modules list (#784)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows selecting minidump module code and debug filepaths to be
scrubbed. The basename of these filepaths are preserved in order to
ensure we can still process the minidumps.