feat: Add Session Aggregates as new Item #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2020
Swatinem
force-pushed
the
feature/session-batches
branch
from
2a3a8f0
to
53fbf91
Compare
Swatinem
force-pushed
the
feature/session-batches
branch
from
91c877f
to
5e14bce
Compare
jan-auer
requested changes
Nov 17, 2020
Swatinem
force-pushed
the
feature/session-batches
branch
from
8d38fb6
to
2cb02a5
Compare
The new sessions item has pre-aggregated counts for different session outcomes. It is configurable if the aggregation should be exploded into individual session updates, or rather sent as aggregates to the kafka topic.
Swatinem
force-pushed
the
feature/session-batches
branch
from
2cb02a5
to
458c348
Compare
jan-auer
approved these changes
Nov 18, 2020
untitaker
approved these changes
Nov 18, 2020
Swatinem
added a commit
that referenced
this pull request
Jan 20, 2021
The compatibility mode was added in #815 because it was waiting on proper support in snuba. That downstream support was added recently in getsentry/snuba#1492, and compatibility mode was switched off in production via a configuration change. Also, the snuba change was included in the 21.1 CalVer release, so it is fine to remove compatibility mode and ship this feature in full fidelity in 21.2.
Swatinem
added a commit
that referenced
this pull request
Jan 21, 2021
The compatibility mode was added in #815 because it was waiting on proper support in snuba. That downstream support was added recently in getsentry/snuba#1492, and compatibility mode was switched off in production via a configuration change. Also, the snuba change was included in the 21.1 CalVer release, so it is fine to remove compatibility mode and ship this feature in full fidelity in 21.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a more efficient envelope item for sending lots of sessions up that happened in the same minute.
Right now they are exploded in relay, but in the future they will be stored directly as-is.