ref(metrics): Send network outage metric on healthcheck endpoint hit #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beezz
force-pushed
the
ref/send-network-outage-metrics-from-healthcheck
branch
from
0be2349
to
5582459
Compare
beezz
force-pushed
the
ref/send-network-outage-metrics-from-healthcheck
branch
from
5582459
to
0e415c3
Compare
tonyo
reviewed
Nov 26, 2020
tonyo
approved these changes
Nov 26, 2020
jan-auer
requested changes
Nov 26, 2020
beezz
force-pushed
the
ref/send-network-outage-metrics-from-healthcheck
branch
from
0e415c3
to
a057366
Compare
untitaker
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
I would do it the other way around: push network outage state from the upstream actor into the healthcheck actor.
The original idea with the healthcheck actor was that one would not overload any other actor's mailboxes with healthcheck-related messages.
I wonder whether emitting the gauge so often is even necessary. Perhaps we can set it only if the state changes, and then only frmo within the upstream actor?
beezz
force-pushed
the
ref/send-network-outage-metrics-from-healthcheck
branch
from
dc8cb40
to
c790cd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.