fix(server): Add missing fields for security reports #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the missing fields: "scheme", "failure-mode" and "test-report" to the ExpectCT security report. This brings the schema in compliance with the Expect-CT Extension for HTTP draft 8 specification.
jan-auer
force-pushed
the
fix/security-fields
branch
from
acb9c97
to
01f0e6f
Compare
RaduW
approved these changes
Dec 2, 2020
jan-auer
commented
Dec 2, 2020
| effective_expiration_date: Option<DateTime<Utc>>, | ||
| served_certificate_chain: Option<Vec<String>>, | ||
| validated_certificate_chain: Option<Vec<String>>, | ||
| scts: Option<Vec<SingleCertificateTimestampRaw>>, | ||
| failure_mode: Option<String>, |
There was a problem hiding this comment.
The failure mode is listed as mandatory in #843, can we make it non-optional or are some browsers actually omitting it?
There was a problem hiding this comment.
We went for all fields as optional. I don't think there is a downside to this. When we get a security report we'll collect from it what we can and create an event. Why would we reject a report and not create an event from it when a user agent doesn't send us a particular field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the fields
scheme,failure-modeandtest-reportthat were missing from the Expect-CT security report.This brings the schema in compliance with the Expect-CT Extension for HTTP draft 8 specification.
This PR addresses the final part of #843 .