Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): Extract crashpad annotations into contexts #892

Merged
merged 3 commits into from
Dec 21, 2020

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Dec 21, 2020

Crashpad stores global and per-module annotations in the minidump. This PR
extracts these annotations into custom contexts to show them on the event.

Each module creates its own module with type crashpad and named after the
basename of the code file. The only exception are global annotations, which get
put into a context named crashpad.


Example from Electron SDK:

image

@jan-auer jan-auer requested a review from a team December 21, 2020 12:22
@jan-auer
Copy link
Member Author

jan-auer commented Dec 21, 2020

cc @flub
cc @HazAT since this indirectly affects Electron.

@jan-auer jan-auer merged commit f5ec7a7 into master Dec 21, 2020
@jan-auer jan-auer deleted the feat/extract-crashpad-annotations branch December 21, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants