New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics): Disallow empty metric names, require alphabetic start #952

Merged

jjbayer merged 2 commits into master from fix/metrics-empty-names

Mar 18, 2021

Member

jjbayer commented Mar 18, 2021

Metric names in the protocol must consist of at least one character.

In addition, require a letter as first character to prevent purely numeric / special character names.


          fix(metrics): Disallow empty metric names, require alphabetic start

2080c11

jjbayer requested a review from a team

March 18, 2021 07:21

jan-auer approved these changes

View reviewed changes

Member

jan-auer left a comment

Can you please also update the doc strings, particularly on Metric::name to reflect this?


          doc(metrics): Document metric names, add changelog

1aa5870

jjbayer merged commit 4b615b9 into master

jjbayer deleted the fix/metrics-empty-names branch

March 18, 2021 07:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment