feat: Replace unicode-id crate with unicode-id-start
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've gone full circle 馃槄 The `unicode-id` and `unicode-id-start` crates were cloned from (`unicode-xid`)(https://crates.io/crates/unicode-xid) and [`unicode-ident`](https://crates.io/crates/unicode-ident) for usages in the [oxc project](https://github.com/oxc-project/oxc). Oxc will be using this crate for sourcemap support, and is currently using the better optimized `unicode-id-start` crate. I don't want to include two similar dependencies due to the rather large static storage size of these crates. The `unicode-id-start` crate is also faster and uses slightly less static storage. See full details at https://github.com/oxc-project/unicode-id-start/tree/master?tab=readme-ov-file#comparison-of-performance --- The version "1" is used instead of the latest version because the crate is stable, future versions will only include unicode version upgrades.
|
For detecting JavaScript identifiers, oxc has an optimized routine which this crate could use. I can add the code to |
Swatinem
approved these changes
Feb 27, 2024
Swatinem
reviewed
Feb 27, 2024
|
lgtm Though I believe this whole module, and |
|
Fixed the clippy warning, ready to merge, and possibly a release 馃榿 |
Swatinem
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've gone full circle 馃槄
The
unicode-idandunicode-id-startcrates were cloned fromunicode-xidandunicode-identfor usages in the oxc project.Oxc will be using this crate for sourcemap support, and is currently using the better optimized
unicode-id-startcrate. I don't want to include two similar dependencies due to the rather large static storage size of these crates.The
unicode-id-startcrate is also faster and uses slightly less static storage. See full details at https://github.com/oxc-project/unicode-id-start/tree/master?tab=readme-ov-file#comparison-of-performanceThe version "1" is used instead of the latest version because the crate is stable, future versions will only include unicode version upgrades.
And thank you Sentry for the sponsorship due to the inclusion of
unicode-idcrate 鉂わ笍