Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: using FxHashMap instead of HashMap #83

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

underfin
Copy link
Contributor

@underfin underfin commented Mar 15, 2024

Improve performance for hashmap hash. ref https://nnethercote.github.io/perf-book/hashing.html.

image

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in #84 , the name_map/names and source_map/sourcesshould really be anIndexSet`.

@Swatinem Swatinem merged commit 16dab53 into getsentry:master Mar 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants