Add support for custom DotEnv file #1113
Conversation
install/wrap-up.sh
Outdated
| @@ -18,7 +18,7 @@ else | |||
| echo "" | |||
| echo "You're all done! Run the following command to get Sentry running:" | |||
| echo "" | |||
| echo " docker-compose up -d" | |||
| echo " docker-compose --env-file ${_ENV} up -d" | |||
There was a problem hiding this comment.
We should not show the --env-file option if we are using the default .env file as that would be quite confusing.
There was a problem hiding this comment.
I think you can benefit from the changes in #1116
There was a problem hiding this comment.
I've changed this.
| @@ -12,6 +12,16 @@ Official bootstrap for running your own [Sentry](https://sentry.io/) with [Docke | |||
|
|
|||
| ## Setup | |||
|
|
|||
| ### Customize DotEnv (.env) file | |||
There was a problem hiding this comment.
We may want to lift this part up into https://develop.sentry.dev/self-hosted/#configuration
There was a problem hiding this comment.
Good point. But I guess it makes sense to leave this information here as well.
I've created a pull request for the documentation change: getsentry/develop#460
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
Sorry for the delay. I'll take a look at it by latest next week. |
Sebbo94BY
force-pushed
the
Add-support-for-custom-env-file
branch
from
c777234
to
9b8792b
Compare
pull changes from origin
Sebbo94BY
force-pushed
the
Add-support-for-custom-env-file
branch
from
9b8792b
to
9240b3f
Compare
|
@chadwhitacre I've rebased this to solve the file conflicts. Do you have any news regarding this change? |
|
Thanks for topping this up @Sebi94nbg, let me try to get to this here ... |
|
Looks good, thanks for seeing this through @Sebi94nbg! Setting this to automerge, once this lands I'll follow up with getsentry/develop#460. 👍 |
This merge request will...
.envfile.env.customto.gitignore, so that Git will ignore changes regarding this file.env.customfile to the readmeMotivation:
The
.envfile provides environment specific configurations, which can be always different at each installation. Docker uses by default the.envfile. Using the parameter--env-file[1], you can define a custom file.Usually, you want to have your installation clean, so Git should not report any unstaged / uncommitted changes, when you change environment specific settings and run
git status.Since the
.envfile is currenlty in Git, we need a custom file, which is not in Git.Refs: