Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak issue forms #1159

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Tweak issue forms #1159

merged 1 commit into from
Nov 18, 2021

Conversation

chadwhitacre
Copy link
Member

@chadwhitacre chadwhitacre commented Nov 18, 2021 •
edited

  1. Expand "Bug Report" to "Problem Report" to also cover support requests. With Deprecate forum in favor of GitHub Issues #1151 we're explicitly asking for support requests to be filed here in Issues.
  2. Rename files to keep up with (1) and for clarity.

@chadwhitacre
Tweak issue forms
f18c92a 
- Expand "Bug Report" to "Problem Report" to cover support requests
- Rename files to keep up and for clarity
chadwhitacre
chadwhitacre commented Nov 18, 2021
View reviewed changes
.github/ISSUE_TEMPLATE/problem-report.yml
@@ -40,7 +40,7 @@ body:
- type: markdown
attributes:
value: |-
## Thanks 🙏
## Thanks
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentry style guide sez no emoji in corporate voice.

@chadwhitacre chadwhitacre enabled auto-merge (squash) November 18, 2021 18:09
@chadwhitacre
Copy link
Member Author

You probably can't review PRs, can you @aminvakil?

aminvakil
aminvakil approved these changes Nov 18, 2021
View reviewed changes
Copy link
Collaborator

@aminvakil aminvakil left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me!
I don't think my approve counts if that's what you mean, but let's see :)

Well it didn't :(

@chadwhitacre chadwhitacre merged commit c7d5798 into master Nov 18, 2021
@chadwhitacre chadwhitacre deleted the cwlw/tweak-issues-intake branch November 18, 2021 21:29
@chadwhitacre
Copy link
Member Author

Overrode review requirement for now. Thanks @aminvakil. :)

This was referenced Nov 18, 2021
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2021
@chadwhitacre chadwhitacre added this to the Forum → Issues milestone Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aminvakil aminvakil aminvakil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Forum → Issues
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chadwhitacre @aminvakil