Docs and output tinkering for commit check #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadwhitacre
commented
Dec 6, 2021
| @@ -4,14 +4,20 @@ show_help() { | |||
| cat <<EOF | |||
| Usage: $0 [options] | |||
|
|
|||
| Install Sentry with `docker compose`. | |||
| Install Sentry with \`docker compose\`. | |||
There was a problem hiding this comment.
Oops. Backticks spawn a subshell here, need to escape them. Regression in #1179.
chadwhitacre
commented
Dec 6, 2021
| --skip-commit-check Skip the check for the latest commit when on the master | ||
| branch of a \`self-hosted\` Git working copy. | ||
| --skip-user-prompt Skip the initial user creation prompt (ideal for non- | ||
| interactive installs). |
There was a problem hiding this comment.
Opportunistic reformat for 80-char lines, sort alphabetically.
chadwhitacre
commented
Dec 6, 2021
| @@ -22,7 +28,8 @@ SKIP_COMMIT_CHECK="${SKIP_COMMIT_CHECK:-}" | |||
| while (( $# )); do | |||
| case "$1" in | |||
| -h | --help) show_help; exit;; | |||
| --no-user-prompt) SKIP_USER_PROMPT=1;; | |||
| --no-user-prompt) SKIP_USER_PROMPT=1;; # deprecated | |||
| --skip-user-prompt) SKIP_USER_PROMPT=1;; | |||
There was a problem hiding this comment.
We shouldn't have --no-* for one and --skip-* for the other. Let's standardize on --skip.
chadwhitacre
changed the title
BYK
approved these changes
Dec 7, 2021
aminvakil
approved these changes
Dec 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick follow-up to #1186, primarily to add the grouping we have in the other subscripts, and to give feedback when skipped.