Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Temporary fix for interactive prompt on createuser #1370

Merged
merged 5 commits into from Mar 11, 2022
Merged

ci: Temporary fix for interactive prompt on createuser #1370

merged 5 commits into from Mar 11, 2022

Conversation

BYK
Copy link
Collaborator

@BYK BYK commented Mar 10, 2022

Fixes #1341 temporarily.

Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
I'm not gonna bother you why this worked on v2.0.1 :)

@BYK
Copy link
Collaborator Author

BYK commented Mar 10, 2022

I'm not gonna bother you why this worked on v2.0.1 :)

Very likely because of the earlier stdin related issues they have on v2.0.1. Note that it says Aborted on the logs for that line so it wasn't really working, it was just quitting at that step since stdin was not available.

Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMPOSE_PROJECT_NAME is not working.

If you want to, we can remove it from this PR and re-open #1367 for that.

@BYK
Copy link
Collaborator Author

BYK commented Mar 11, 2022

@aminvakil

COMPOSE_PROJECT_NAME is not working.

It is working: Container self-hosted-0-postgres-1

Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! I saw this:
Successfully tagged sentry-cleanup-self-hosted-local:latest
and I was mistaken that images created should have -0- too.

It is working indeed: https://github.com/getsentry/self-hosted/runs/5494674968?check_suite_focus=true#step:4:1853

@chadwhitacre
Copy link
Member

Ok but why does it work?

Copy link
Member

@chadwhitacre chadwhitacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this works but it seems to work and doesn't look that bad.

@chadwhitacre chadwhitacre merged commit de81299 into getsentry:master Mar 11, 2022
@BYK BYK deleted the byk/ci/fix-interactive branch March 12, 2022 12:32
@BYK
Copy link
Collaborator Author

BYK commented Mar 12, 2022

I don't understand why this works but it seems to work and doesn't look that bad.

This works because I feed a y to the interactive prompt here: https://github.com/getsentry/self-hosted/pull/1370/files#diff-e386fde36977f06e32a6c6dbe63595743f0721ca78fcae81414fbdc0ca837b24R44

So instead of waiting for input indefinitely, it just moves along. The real fix is making the code I mentioned over #1341 (comment) not ask for a prompt when --no-input is passed or the stdin is not a tty.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI flakes with "The operation was canceled."
3 participants