Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker volumes for persistent data. #19

Closed
wants to merge 1 commit into from

Conversation

buckett
Copy link

@buckett buckett commented Nov 10, 2016

Using docker volumes makes this more portable than mounting volumes from the host OS.

Fixes #18

Using docker volumes makes this more portable than mounting volumes from the host OS.

Fixes getsentry#18
@mattrobenolt
Copy link
Contributor

I'm not entirely sure I agree with this nor am I entirely sure I'd want to advocate using docker volumes 100% of the time. This is meant to be more of a guideline and meant for you to adapt to your infrastructure. So I'm trying hard not to dictate these minor implementation details.

Now regretting even attempting to supply a docker-compose.yml. I might remove it entirely and leave it as an exercise for the reader.

@buckett
Copy link
Author

buckett commented Nov 11, 2016

I was just suggesting it as as long as you're on a version of docker that supports it it seems to be more predictable. If nothing else if someone gets the same error they might at least be able google it, end up at the issue and see that they might be able to workaround it.

@mattrobenolt
Copy link
Contributor

I was just suggesting it as as long as you're on a version of docker that supports it it seems to be more predictable.

I personally disagree that it's more predictable. :) But ultimately these decisions are personal and have pros and cons in each situation and environment. We run docker in production for sentry.io and much prefer mounting volumes from disk rather than using docker volumes, for example.

@mattrobenolt
Copy link
Contributor

I will say though that tinkering with stuff locally, I'd prefer a docker volume. Where as in a production deployment, I would not.

@buckett buckett deleted the docker-volumes branch May 11, 2017 14:28
@trurl123
Copy link

This PR really helps me! I could not install Sentry without it.

mrijke pushed a commit to mrijke/sentry-onpremise-dokku that referenced this pull request Feb 1, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to run on OSX (permission denied)
3 participants