Uninstall Docker Compose v1 from CI so it's not used for tests #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertdeng123
force-pushed
the
hubertdeng123/test-docker-compose
branch
2 times, most recently
from
56cc302
to
1633845
Compare
hubertdeng123
changed the title
docker-compose in v2
hubertdeng123
force-pushed
the
hubertdeng123/test-docker-compose
branch
from
b598c1a
to
c9eeeb2
Compare
hubertdeng123
force-pushed
the
hubertdeng123/test-docker-compose
branch
from
a9c1fc7
to
9f09714
Compare
hubertdeng123
commented
Apr 28, 2023
| @@ -11,24 +11,24 @@ echo "Creating backup..." | |||
| touch $(pwd)/sentry/backup.json | |||
| chmod 666 $(pwd)/sentry/backup.json | |||
| # Command here matches exactly what we have in our docs https://develop.sentry.dev/self-hosted/backup/#backup | |||
| docker-compose run -v $(pwd)/sentry:/sentry-data/backup --rm -T -e SENTRY_LOG_LEVEL=CRITICAL web export /sentry-data/backup/backup.json | |||
| $dc run -v $(pwd)/sentry:/sentry-data/backup --rm -T -e SENTRY_LOG_LEVEL=CRITICAL web export /sentry-data/backup/backup.json | |||
There was a problem hiding this comment.
using $dc since our scripts do some pre-script setup that is failing CI (error-handling, dc-detect-version, detect-platform, trap)
There was a problem hiding this comment.
Yisss, exactly the cases we wanted to fix.
BYK
approved these changes
Apr 28, 2023
.github/workflows/test.yml
Outdated
Comment on lines
71
to
72
| # Docker Compose v1 is installed here, remove it | ||
| sudo rm -f "/usr/local/bin/docker-compose" |
There was a problem hiding this comment.
Let's move this up, next to other rm commands.
There was a problem hiding this comment.
This should be after downloading docker-compose, right?
There was a problem hiding this comment.
Doesn't really matter. I'd do it before to be consistent and not accidentally delete the downloaded one.
| @@ -11,24 +11,24 @@ echo "Creating backup..." | |||
| touch $(pwd)/sentry/backup.json | |||
| chmod 666 $(pwd)/sentry/backup.json | |||
| # Command here matches exactly what we have in our docs https://develop.sentry.dev/self-hosted/backup/#backup | |||
| docker-compose run -v $(pwd)/sentry:/sentry-data/backup --rm -T -e SENTRY_LOG_LEVEL=CRITICAL web export /sentry-data/backup/backup.json | |||
| $dc run -v $(pwd)/sentry:/sentry-data/backup --rm -T -e SENTRY_LOG_LEVEL=CRITICAL web export /sentry-data/backup/backup.json | |||
There was a problem hiding this comment.
Yisss, exactly the cases we wanted to fix.
aminvakil
approved these changes
Apr 28, 2023
chadwhitacre
approved these changes
May 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will uninstall docker compose v1.29 from CI so
docker-composecannot be used.CI runs to indicate this is the case: