Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command called in reset script #2254

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

stayallive
Copy link
Contributor

Looks like this was missed in #2029, running reset.sh now runs the bash reset and just resets the console 😅

@hubertdeng123
Copy link
Member

The purpose of this script is actually to run the clean function that lives in the scripts/_lib.sh file. Was this something that was unclear? What would you have wanted the functionality to be?

@stayallive
Copy link
Contributor Author

stayallive commented Jul 6, 2023

Well yes. But the cmd in the file was defined as “reset” and not “clean”, see the diff, so the wrong function is called.

So as is, it calls “reset” instead of the expected “clean” function and this fixed that 🤘

@hubertdeng123
Copy link
Member

Well yes. But the cmd in the file was defined as “reset” and not “clean”, see the diff, so the wrong function is called.

There actually isn't a reset function in the file. Maybe what might be cleaner is changing clean -> reset in scripts/_lib.sh?

@stayallive
Copy link
Contributor Author

stayallive commented Jul 6, 2023

Sure, that also works too, updated 👍

@hubertdeng123
Copy link
Member

thanks for catching this @stayallive

@hubertdeng123 hubertdeng123 enabled auto-merge (squash) July 6, 2023 22:03
@hubertdeng123 hubertdeng123 merged commit 5e1e74b into getsentry:master Jul 7, 2023
6 checks passed
@stayallive stayallive deleted the patch-1 branch July 8, 2023 08:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants