Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize backup restore script #2412

Merged

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Sep 20, 2023

Allows users to call

./scripts/backup.sh (users/organizations/config)
./scripts/restore.sh (users/organizations/config)

Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep it backward compatible for anyone who might use this script some another way.

scripts/_lib.sh Outdated
@@ -60,13 +60,15 @@ function reset() {
}

function backup() {
type=$1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type=$1
type=${1:-"global"}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good suggestion!

@getsantry getsantry bot added the Stale label Oct 18, 2023
@ricardoapaes
Copy link

It will be of great help to us. I'm waiting for the merge!

@hubertdeng123 hubertdeng123 force-pushed the hubertdeng123/parameterize-backup-restore-script branch from 1c7672a to c31e5bf Compare January 12, 2024 20:17
@hubertdeng123 hubertdeng123 force-pushed the hubertdeng123/parameterize-backup-restore-script branch from c31e5bf to ee013c9 Compare January 12, 2024 20:19
Copy link
Contributor

@azaslavsky azaslavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the docs to mention this as well

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Jan 12, 2024

We should update the docs to mention this as well

agreed

@hubertdeng123 hubertdeng123 merged commit 168330c into master Jan 16, 2024
8 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/parameterize-backup-restore-script branch January 16, 2024 16:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants