Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kafka and zookeeper versions #2988

Merged
merged 9 commits into from
Apr 30, 2024

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Apr 22, 2024

let's try this getting this to 7.6.1 so we can get rid of zookeeper

more details: https://docs.confluent.io/platform/current/installation/migrate-zk-kraft.html

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (f84bb3d) to head (00959b3).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2988   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files           3        3           
  Lines         203      203           
=======================================
  Hits          201      201           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hubertdeng123
Copy link
Member Author

tested it on our dogfood instance, seems to work

@aldy505
Copy link
Collaborator

aldy505 commented Apr 22, 2024

Dupe of #2919?

@hubertdeng123
Copy link
Member Author

Dupe of #2919?

Yes, but wanted an easier way of working locally with the changes. I'll merge the dupe before this one if we decide to go to 7.6.1, since that has the capability of getting rid of zookeeper

@hubertdeng123 hubertdeng123 force-pushed the hubertdeng123/bump-kafka-zookeeper branch from 5ca30be to bfe77b8 Compare April 23, 2024 00:09
@hubertdeng123 hubertdeng123 force-pushed the hubertdeng123/bump-kafka-zookeeper branch from d0e0f20 to dc44224 Compare April 25, 2024 21:55
@hubertdeng123 hubertdeng123 marked this pull request as ready for review April 25, 2024 22:02
@aldy505
Copy link
Collaborator

aldy505 commented Apr 25, 2024

just use Redpanda already, lol

@hubertdeng123 hubertdeng123 force-pushed the hubertdeng123/bump-kafka-zookeeper branch from f6ba6cb to db8bac6 Compare April 26, 2024 00:02
@hubertdeng123 hubertdeng123 force-pushed the hubertdeng123/bump-kafka-zookeeper branch from 9d674e7 to ee35727 Compare April 26, 2024 16:36
@thuvh
Copy link

thuvh commented Apr 28, 2024

@hubertdeng123 well done!

zookeeper_log_data_dir="/var/lib/docker/volumes/sentry-self-hosted_sentry-zookeeper-log/_data"
chmod -R a+w $zookeeper_data_dir $kafka_data_dir $zookeeper_log_data_dir && returncode=$? || returncode=$?
if [[ $returncode == "1" ]]; then
echo "WARNING: Error when setting appropriate permissions for zookeeper, kafka, and zookeeper log docker volumes. This may corrupt your self-hosted install."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we point to a bug or doc with more info? It seems like users could recover from this manually if this script fails for some reason.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linked to a bug to give users more context

@hubertdeng123 hubertdeng123 merged commit 6db528d into master Apr 30, 2024
12 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/bump-kafka-zookeeper branch April 30, 2024 19:32
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants