Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit test file name #3002

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Edit test file name #3002

merged 1 commit into from
Apr 29, 2024

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Apr 26, 2024

We need to do this because snuba test suite because of the rule here for snuba:
https://github.com/getsentry/snuba/blob/671920ff92a229f47e56e1b6708acdbae655dfd8/setup.cfg#L2

test.py is being picked up and fails when pytest runs

CI failing here: getsentry/snuba#5828

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (f84bb3d) to head (236cc4c).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3002   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files           3        3           
  Lines         203      203           
=======================================
  Hits          201      201           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hubertdeng123 hubertdeng123 merged commit 3150263 into master Apr 29, 2024
12 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/rename-file branch April 29, 2024 17:47
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants