Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade test #3012

Merged
merged 6 commits into from
May 2, 2024
Merged

Add upgrade test #3012

merged 6 commits into from
May 2, 2024

Conversation

hubertdeng123
Copy link
Member

This additional coverage will hopefully help catch some bugs introduced from upgrading self-hosted. This is particularly useful for infrastructure upgrades such as clickhouse, kafka, or zookeeper

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (6db528d) to head (11b228a).

❗ Current head 11b228a differs from pull request most recent head 43f2fa6. Consider uploading reports for the commit 43f2fa6 to get more accurate results

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3012   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files           3        3           
  Lines         203      203           
=======================================
  Hits          201      201           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hubertdeng123 hubertdeng123 force-pushed the hubertdeng123/add-upgrade-test branch from 514ca40 to bf94d64 Compare May 2, 2024 18:18
@hubertdeng123 hubertdeng123 marked this pull request as ready for review May 2, 2024 18:29
@hubertdeng123
Copy link
Member Author

Sigh CI is failing due to

chmod: cannot access '/var/lib/docker/volumes/sentry-zookeeper/_data': Permission denied
  chmod: cannot access '/var/lib/docker/volumes/sentry-kafka/_data': Permission denied
  chmod: cannot access '/var/lib/docker/volumes/sentry-self-hosted_sentry-zookeeper-log/_data': Permission denied
  WARNING: Error when setting appropriate permissions for zookeeper, kafka, and zookeeper log docker volumes. This may corrupt your self-hosted install. See https://github.com/confluentinc/kafka-images/issues/127 for context on why this was added.

@hubertdeng123 hubertdeng123 force-pushed the hubertdeng123/add-upgrade-test branch from 11b228a to 43f2fa6 Compare May 2, 2024 19:42
@hubertdeng123 hubertdeng123 enabled auto-merge (squash) May 2, 2024 19:47
@hubertdeng123 hubertdeng123 merged commit 9e36d2f into master May 2, 2024
22 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/add-upgrade-test branch May 2, 2024 20:04
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants