Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install: use dynamic docker root dir instead of hardcoded one #3064

Merged
merged 1 commit into from
May 22, 2024

Conversation

boutetnico
Copy link
Contributor

Avoid using a hardcoded path to docker root dir. Instead, fetch the path dynamically and use it.

Use case: folks using a non standard docker root dir.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@hubertdeng123
Copy link
Member

Thanks for submitting this!

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (f22bc2a) to head (3e57f7e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3064   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files           3        3           
  Lines         203      203           
=======================================
  Hits          201      201           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hubertdeng123 hubertdeng123 merged commit 6032d98 into getsentry:master May 22, 2024
11 checks passed
@cbull-86
Copy link

Please note that this does not work on a WSL2 Windows install as a default docker install keeps its volumes in /mnt/wsl/docker-desktop-data/version-pack-data/community/docker/volumes.
However, docker info will still report Docker Root Dir as /var/lib/docker, which does not exist.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants