Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto-Instrumentation features configuration #245

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jan 3, 2022

#skip-changelog

📜 Description

  • Adds new features configuration option under the tracingInstrumentation sub-extension. This allows specifying a set of features enabled for bytecode manipulation, currently only contains FILE_IO and DATABASE respectively.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 17d0405

@romtsn romtsn force-pushed the feat/instrumentation-features-config branch from b187169 to 0da75b2 Compare January 3, 2022 21:07
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. A few suggestions.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…nstrumentationExtension.kt

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
@romtsn romtsn merged commit e06f1d6 into feat/sentry-android-sdk-version-check Jan 4, 2022
@romtsn romtsn deleted the feat/instrumentation-features-config branch January 4, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants