Populate events with dependencies metadata #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
changed the title
markushi
reviewed
Oct 31, 2022
plugin-build/src/main/kotlin/io/sentry/android/gradle/util/SentryPluginUtils.kt
Outdated
Show resolved
Hide resolved
...build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryExternalDependenciesReportTask.kt
Show resolved
Hide resolved
adinauer
approved these changes
Oct 31, 2022
| val javaExtension = project.extensions.getByType(JavaPluginExtension::class.java) | ||
|
|
||
| val sentryResDir = project.layout.buildDirectory.dir("generated${sep}sentry") | ||
| javaExtension.sourceSets.getByName("main").resources { sourceSet -> |
There was a problem hiding this comment.
m Should we also allow for devs to configure the source set they want?
Maybe even support multiple and have listOf("main") as default?
This could be a separate issue as well.
There was a problem hiding this comment.
hmm, but what would be the usecase? All the sourcesets get packaged into the final jar anyway, and that's what we're interested in
There was a problem hiding this comment.
I was thinking about people renaming the source sets because they're following some conventions or have to support some legacy code base where names are different.
4 tasks
markushi
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
馃挕 Motivation and Context
Closes #236
馃挌 How did you test it?
Manually and automated
馃摑 Checklist
馃敭 Next steps