Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename experimentalGuardsquareSupport flag to dexguardEnabled #589

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Rename experimentalGuardsquareSupport flag to dexguardEnabled #589

merged 3 commits into from
Nov 6, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Nov 3, 2023 •
edited

馃摐 Description

  • Rename experimentalGuardsquareSupport flag to dexguardEnabled
  • Add tracking for dexguard so we can see its adoption

馃挕 Motivation and Context

Closes #518

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

  • Update docs for v4

markushi
markushi approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romtsn romtsn merged commit 47e9ba4 into main Nov 6, 2023
18 checks passed
@romtsn romtsn deleted the rz/chore/dexguard-flag branch November 6, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

experimentalGuardsquareSupport is still experimental
2 participants
@romtsn @markushi