Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new 'excludes' option to exclude classes from instrumentation #590

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Add new 'excludes' option to exclude classes from instrumentation #590

merged 4 commits into from
Nov 9, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Nov 6, 2023

馃摐 Description

  • Add new excludes option to exclude classes from instrumentation. The option just wires to the existing excludes API from AGP, and only available on AGP 7.4+

馃挕 Motivation and Context

Closes #306
Closes #218

馃挌 How did you test it?

Manually + automated

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

  • Update docs

@romtsn romtsn merged commit b0bd411 into main Nov 9, 2023
17 checks passed
@romtsn romtsn deleted the rz/feat/instrumentation-excludes branch November 9, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow excluding certain libs from instrumentation Option to ignore spans coming from 3rd party dependencies
2 participants
@romtsn @markushi