Fix VerifyError when optimized code is instrumented #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| override fun onMethodEnter() { | ||
| super.onMethodEnter() | ||
| // add local variables, this seems to confuse the optimizer enough |
stefanosiano
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
App startup instrumentation fails for some pre-bundled libraries due to bytecode optimizations which produce non spec-compliant JVM bytecode.
As an example the stack frame variable of member functions at index 0 is not a
thisreference anymore.This mainly affects
ContentProviderinstrumentation as those (opposed toApplicationclasses) are usually shipped within libraries.Affected Examples:
com.google.mlkit.common.internal.MlKitInitProviderandroidx.startup.InitializationProvider馃挕 Motivation and Context
Fixes #618
馃挌 How did you test it?
Manual testing
馃摑 Checklist
馃敭 Next steps