Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sentry-cli path calculation configuration-cache compatible #631

Merged
merged 16 commits into from
Jan 15, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jan 10, 2024

#skip-changelog

馃摐 Description

  • Use ValueSource or project.provider to defer sentry-cli path calculation to the point where it's actually needed

馃挕 Motivation and Context

Closes #613

馃挌 How did you test it?

Manually and automated

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; changelog needs to be moved ah nevermind

@romtsn romtsn merged commit fd1e531 into main Jan 15, 2024
17 checks passed
@romtsn romtsn deleted the rz/fix/sentry-cli-config-cache-compatible branch January 15, 2024 10:03
@xianfeng-zhu
Copy link

馃殌

@nuhkoca
Copy link

nuhkoca commented Jan 15, 2024

When can we except a new version as we've been struggling this issue for a while now?

@romtsn
Copy link
Member Author

romtsn commented Jan 16, 2024

we're gonna ship it this week (likely tomorrow CET time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failures regarding sentry-cli7059257849644749494.exe on macOS
4 participants