Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run sentry-cli commands if telemetry is disabled #648

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Do not run sentry-cli commands if telemetry is disabled #648

merged 3 commits into from
Feb 2, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Feb 1, 2024

馃摐 Description

  • Do not run sentry-cli commands if telemetry is disabled
  • Add --log-level=error for the sentry-cli info command to prevent printing this message
INFO    2024-01-08 10:16:18.758013 +01:00 Loaded file referenced by SENTRY_PROPERTIES (<redacted>)
  • Uncomment telemetry tests as they should be working now
  • ignoreExitValue for deleting lock files, this should fix failures on AGP 8.4.0-alpha06 on main

馃挕 Motivation and Context

Closes #626

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

stefanosiano
stefanosiano approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@romtsn romtsn merged commit afa92e8 into main Feb 2, 2024
18 checks passed
@romtsn romtsn deleted the rz/fix/disabled-telemetry-calls-cli branch February 2, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanosiano stefanosiano stefanosiano approved these changes

@markushi markushi Awaiting requested review from markushi markushi is a code owner

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telemetry sentry-cli commands executed with telemetry=false
2 participants
@romtsn @stefanosiano