Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not package dev.gradleplugins within the plugin #677

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Do not package dev.gradleplugins within the plugin #677

merged 4 commits into from
Mar 21, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Mar 20, 2024

馃摐 Description

馃挕 Motivation and Context

Closes #676
Closes #656

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

markushi
markushi approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romtsn romtsn merged commit d89273a into main Mar 21, 2024
18 checks passed
@romtsn romtsn deleted the rz/fix/groovy-packaged branch March 21, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@romtsn @markushi