Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular dependency for minify/dexguard #678

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

markushi
Copy link
Member

@markushi markushi commented Mar 25, 2024

馃摐 Description

Based on the task graph for R8/DG, mergeDex<Variant> is the closest to minify<Variant>WithR8.

  1. hooked ProGuard UUID gen task to the minify/mergeDex tasks
  2. hooked UUID upload to assemble task (same as source context)

馃挕 Motivation and Context

Fixes #679

Not sure if we still need transformClassesAndResourcesWithProguardTransformFor*!?

馃挌 How did you test it?

Manual testing with example app.

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markushi markushi merged commit 2ea612f into main Mar 25, 2024
20 checks passed
@markushi markushi deleted the fix/dexguard-circular-dependency branch March 25, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry Android Gradle Plugin doesn't work with DexGuard
2 participants