Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually wire up copyFlutterAssets task #723

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Conversation

markushi
Copy link
Member

馃摐 Description

Flutter isn't using the transform API to add generated sources, and thus breaks our Android transform API approach.
Simply wire up the task manually until flutter will eventually switch to the transform API as well.

More details on the overall problem: https://www.notion.so/sentry/ProGuard-Mapping-File-upload-sentry-vs-the-rest-e90c1fd768a94bfdb4e0a9ad0ac80503?pvs=4#42b4620bf43349ae9fd091b7c36dda0a

馃挕 Motivation and Context

Fixes #701

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter is shiet

@markushi markushi merged commit cbebbf9 into main Jun 18, 2024
18 checks passed
@markushi markushi deleted the fix/flutter-task-dependencies branch June 18, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing copyFlutterAssetsDebug task dependency
3 participants