Auto install and instrument sentry-okhttp instead of sentry-android-okhttp on v7+ #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add sentry-okhttp module to autoInstall if Sentry v7+ changed OkHttp instrumentation to use sentry-okhttp instead of sentry-android-okhttp if Sentry v7+
fixed formatting
|
markushi
approved these changes
Jun 21, 2024
.../src/main/kotlin/io/sentry/android/gradle/autoinstall/okhttp/AndroidOkHttpInstallStrategy.kt
Outdated
Show resolved
Hide resolved
…all/okhttp/AndroidOkHttpInstallStrategy.kt Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Added auto installation of
sentry-okhttponly (withoutsentry-android-okhttp) when using sentry 7+Auto instrumented
sentry-okhttpdirectly instead ofsentry-android-okhttpwhen using sentry 7+When using older version, nothing changed
💡 Motivation and Context
Closes second step of #601
We want to remove the
sentry-android-okhttpartifact and rely solely onsentry-okhttp💚 How did you test it?
Unit tests
📝 Checklist
🔮 Next steps