Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Split event processor in Device/App data #180

Merged
merged 5 commits into from Dec 6, 2019

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Dec 3, 2019

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

Split event processor in Device/App data.
For events being processed after app restart, no app data is to be applied.
Device data can be applied to in-memory events and cached events.

馃挕 Motivation and Context

if App. crashes for example and you update your App., data is still gonna be applied and the App. will be the newer version, this is wrong.

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

馃敭 Next steps

@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #180 into master will increase coverage by 0.07%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #180      +/-   ##
============================================
+ Coverage      57.9%   57.97%   +0.07%     
- Complexity      543      545       +2     
============================================
  Files            72       72              
  Lines          2599     2601       +2     
  Branches        228      227       -1     
============================================
+ Hits           1505     1508       +3     
  Misses          977      977              
+ Partials        117      116       -1
Impacted Files Coverage 螖 Complexity 螖
...c/main/java/io/sentry/core/MainEventProcessor.java 71.87% <91.66%> (+1.87%) 7 <3> (+1) 猬嗭笍
...c/main/java/io/sentry/core/DirectoryProcessor.java 74.07% <0%> (+3.7%) 7% <0%> (+1%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0a5599f...1726e95. Read the comment docs.

@marandaneto marandaneto changed the title wip Split event processor in Device/App data Dec 6, 2019
@marandaneto marandaneto marked this pull request as ready for review December 6, 2019 10:44
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruno-garcia I approve my own tests :D but please review it.

@bruno-garcia
Copy link
Member Author

Thanks for fixing this @marandaneto

@bruno-garcia bruno-garcia merged commit 835086a into master Dec 6, 2019
@bruno-garcia bruno-garcia deleted the feat/cached-events-scope branch December 6, 2019 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants