Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Remove redundant times(1) for Mockito.verify #211

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Remove redundant times(1) for Mockito.verify #211

merged 1 commit into from
Jan 9, 2020

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jan 9, 2020

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

In some parts of the unit tests Mockito.verify(something, times(1)).someMethod() is used. This can be simplified to Mockito.verify(something).someMethod().

馃挕 Motivation and Context

It makes the code simpler and less verbose.

馃挌 How did you test it?

By running the tests.

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

馃敭 Next steps

None.

@codecov-io
Copy link

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #211   +/-   ##
=========================================
  Coverage     58.46%   58.46%           
  Complexity      561      561           
=========================================
  Files            73       73           
  Lines          2634     2634           
  Branches        231      231           
=========================================
  Hits           1540     1540           
  Misses          978      978           
  Partials        116      116

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 058caae...7999338. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philipphofmann thanks a lot :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants