Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Raise code coverage for Dsn to 100% #212

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Raise code coverage for Dsn to 100% #212

merged 2 commits into from
Jan 9, 2020

Conversation

philipphofmann
Copy link
Member

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

The code coverage for Dns is raised to 100% with this PR.

馃挕 Motivation and Context

It is better to have a higher code coverage to be able to change code later. Furthermore, one TODO is removed.

馃挌 How did you test it?

With unit tests.

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

馃敭 Next steps

None.

@philipphofmann philipphofmann changed the title Raise code coverage for Dns to 100% Raise code coverage for Dsn to 100% Jan 9, 2020
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philipphofmann thanks, one TODO less.
keep it up.

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #212 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #212      +/-   ##
============================================
+ Coverage     58.46%   58.58%   +0.11%     
- Complexity      561      564       +3     
============================================
  Files            73       73              
  Lines          2634     2634              
  Branches        231      231              
============================================
+ Hits           1540     1543       +3     
+ Misses          978      975       -3     
  Partials        116      116
Impacted Files Coverage 螖 Complexity 螖
sentry-core/src/main/java/io/sentry/core/Dsn.java 94.11% <100%> (+8.82%) 12 <0> (+3) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 058caae...1e749f9. Read the comment docs.

@marandaneto marandaneto merged commit 8da9343 into getsentry:master Jan 9, 2020
@philipphofmann philipphofmann deleted the ref/dns_code_coverage branch January 9, 2020 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants