clone method - race condition free

[marandaneto]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

clone race condition free.

💡 Motivation and Context

because the clone methods might give some race conditions.

💚 How did you test it?

just ran the tests.

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• All tests passing

🔮 Next steps

[codecov-io]

Codecov Report

Merging #226 into master will decrease coverage by 0.37%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##             master     #226      +/-   ##
============================================
- Coverage     58.27%   57.89%   -0.38%     
+ Complexity      573      567       -6     
============================================
  Files            72       72              
  Lines          2701     2691      -10     
  Branches        231      230       -1     
============================================
- Hits           1574     1558      -16     
- Misses         1016     1018       +2     
- Partials        111      115       +4

Impacted Files	Coverage Δ	Complexity Δ
sentry-core/src/main/java/io/sentry/core/Hub.java	68.63% <80%> (-1.55%)	52 <0> (-3)
...entry-core/src/main/java/io/sentry/core/Scope.java	82.1% <90.9%> (-1.42%)	29 <5> (-1)
...rc/main/java/io/sentry/core/CircularFifoQueue.java	34.95% <0%> (-2.44%)	17% <0%> (-1%)
...try/core/transport/RetryingThreadPoolExecutor.java	53.76% <0%> (-1.08%)	13% <0%> (-1%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3697b4...82156bf. Read the comment docs.

[marandaneto]

@metlos hey :) would you have 2 cents to contribute here?

we aim to be fully thread-safe and guess our clone methods had race conditions, right now I'm using "reference assignment" as it's supposed to be atomic.

I've tried to implement a deep copy, but not sure if I'm happy with it yet.

Also I've changed ArrayList to the Concurrent ones.

Unfortunately, we cannot be fully immutable, so that makes a bit harder.

Thanks :)