Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

always call interrupt after InterruptedException #232

Merged
merged 3 commits into from
Jan 16, 2020

Conversation

marandaneto
Copy link
Contributor

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

always call interrupt after InterruptedException.

馃挕 Motivation and Context

for my understanding, this should be always done if we don't have full control of the thread.
eg https://dzone.com/articles/why-do-we-need-threadcurrentthreadinterrupt-in-int

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

馃敭 Next steps

@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #232 into master will decrease coverage by 0.23%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #232      +/-   ##
============================================
- Coverage     58.93%   58.69%   -0.24%     
+ Complexity      570      569       -1     
============================================
  Files            72       72              
  Lines          2647     2656       +9     
  Branches        235      235              
============================================
- Hits           1560     1559       -1     
- Misses          973      982       +9     
- Partials        114      115       +1
Impacted Files Coverage 螖 Complexity 螖
.../src/main/java/io/sentry/core/protocol/Device.java 0% <0%> (酶) 0 <0> (酶) 猬囷笍
...c/main/java/io/sentry/core/DirectoryProcessor.java 76% <0%> (-4%) 6% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8954ec6...ba675e4. Read the comment docs.

@marandaneto marandaneto merged commit db3d370 into master Jan 16, 2020
@marandaneto marandaneto deleted the fix/interrupt_thread branch January 16, 2020 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants