Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Honor RetryAfter #236

Merged
merged 9 commits into from
Jan 17, 2020
Merged

Honor RetryAfter #236

merged 9 commits into from
Jan 17, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 16, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Honor Sentry RetryAfter.

💡 Motivation and Context

RetryAfter was implemented differently, per event, like the sentry-java SDK, but it's not honoring the unified API.

💚 How did you test it?

unit tests and manual tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@marandaneto marandaneto changed the title Honor RetryAfter WIP - Honor RetryAfter Jan 16, 2020
@marandaneto marandaneto requested review from metlos and bruno-garcia and removed request for metlos January 16, 2020 14:07
@codecov-io
Copy link

codecov-io commented Jan 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@074eeac). Click here to learn what that means.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #236   +/-   ##
=========================================
  Coverage          ?   58.13%           
  Complexity        ?      574           
=========================================
  Files             ?       72           
  Lines             ?     2706           
  Branches          ?      237           
=========================================
  Hits              ?     1573           
  Misses            ?     1014           
  Partials          ?      119
Impacted Files Coverage Δ Complexity Δ
...n/java/io/sentry/core/transport/HttpTransport.java 59.75% <100%> (ø) 6 <0> (?)
...java/io/sentry/core/transport/AsyncConnection.java 60% <100%> (ø) 5 <0> (?)
...try/core/transport/RetryingThreadPoolExecutor.java 53.76% <50%> (ø) 13 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074eeac...0db7a24. Read the comment docs.

@marandaneto marandaneto changed the title WIP - Honor RetryAfter Honor RetryAfter Jan 17, 2020
@marandaneto marandaneto merged commit 27bb71a into master Jan 17, 2020
@marandaneto marandaneto deleted the fix/retry_after branch January 17, 2020 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants