Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

build all ABIs #254

Merged
merged 1 commit into from Jan 29, 2020
Merged

build all ABIs #254

merged 1 commit into from Jan 29, 2020

Conversation

marandaneto
Copy link
Contributor

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

build all ABIs.

馃挕 Motivation and Context

API env. It only makes sense if we have integration tests and emulators, so we actually create emulators based on the APIs (matrix).

ABI env. is the same case, we could speed up builds for specific emulator architectures, but we don't have it now, we can rollback it later when we actually do it.

Another thing is, we want to download the artifacts and CI right now is compiling to specific ABIs, so we could add a new one for all the ABIs or remove them all as I do now, because there's no meaning right now.

馃挌 How did you test it?

let's check CI right now.

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

馃敭 Next steps

@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #254 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #254      +/-   ##
============================================
+ Coverage     57.26%   57.29%   +0.03%     
- Complexity      576      577       +1     
============================================
  Files            73       73              
  Lines          2761     2761              
  Branches        234      234              
============================================
+ Hits           1581     1582       +1     
  Misses         1062     1062              
+ Partials        118      117       -1
Impacted Files Coverage 螖 Complexity 螖
...try/core/transport/RetryingThreadPoolExecutor.java 54.83% <0%> (+1.07%) 14% <0%> (+1%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0a116e0...dec44d1. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bruno-garcia bruno-garcia merged commit 7e62339 into master Jan 29, 2020
@bruno-garcia bruno-garcia deleted the fix/build_all_abis branch January 29, 2020 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants