Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

make integrations public #256

Merged
merged 1 commit into from Jan 31, 2020
Merged

make integrations public #256

merged 1 commit into from Jan 31, 2020

Conversation

marandaneto
Copy link
Contributor

๐Ÿ“ข Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

๐Ÿ“œ Description

make integrations public.

๐Ÿ’ก Motivation and Context

When a user wants to remove an integration, it would be possible doing:
options.getIntegrations() iterating it and comparing instances, but integrations are not public, yet.

๐Ÿ’š How did you test it?

CI

๐Ÿ“ Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

๐Ÿ”ฎ Next steps

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amen brother

@codecov-io
Copy link

codecov-io commented Jan 31, 2020

Codecov Report

Merging #256 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #256   +/-   ##
=========================================
  Coverage     57.26%   57.26%           
  Complexity      576      576           
=========================================
  Files            73       73           
  Lines          2761     2761           
  Branches        234      234           
=========================================
  Hits           1581     1581           
  Misses         1062     1062           
  Partials        118      118
Impacted Files Coverage ฮ” Complexity ฮ”
...ntry/core/UncaughtExceptionHandlerIntegration.java 76.19% <รธ> (รธ) 9 <0> (รธ) โฌ‡๏ธ
.../core/SendCachedEventFireAndForgetIntegration.java 78.57% <รธ> (รธ) 4 <0> (รธ) โฌ‡๏ธ

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 71dce6a...0736327. Read the comment docs.

@marandaneto marandaneto merged commit 89439ba into master Jan 31, 2020
@marandaneto marandaneto deleted the fix/public_integrations branch January 31, 2020 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants