Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

fix: breacrumb.data to string,object, Add LOG level #264

Merged
merged 7 commits into from Feb 11, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Feb 11, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Add fix that breadcrumb.data is <String, Object> instead of <String, String>
Add LOG as log level.

💡 Motivation and Context

Support for Hybrid SDKs

💚 How did you test it?

unit test.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

🚢

@codecov-io
Copy link

codecov-io commented Feb 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@7ad3716). Click here to learn what that means.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #264   +/-   ##
=========================================
  Coverage          ?   57.28%           
  Complexity        ?      577           
=========================================
  Files             ?       73           
  Lines             ?     2774           
  Branches          ?      235           
=========================================
  Hits              ?     1589           
  Misses            ?     1068           
  Partials          ?      117
Impacted Files Coverage Δ Complexity Δ
...core/src/main/java/io/sentry/core/SentryLevel.java 100% <ø> (ø) 1 <0> (?)
...y-core/src/main/java/io/sentry/core/DateUtils.java 55.55% <0%> (ø) 4 <0> (?)
...ntry/core/UncaughtExceptionHandlerIntegration.java 76.56% <100%> (ø) 9 <0> (?)
.../core/SendCachedEventFireAndForgetIntegration.java 81.81% <100%> (ø) 4 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad3716...8ccc3d9. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 4381ff4 into master Feb 11, 2020
@marandaneto marandaneto deleted the fix/breadcrumbs-data-log-level branch February 11, 2020 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants