fix: preview package manager #269
Conversation
| @@ -227,10 +227,10 @@ private SdkVersion getSdkVersion() { | |||
| sdkVersion.setName("sentry.java.android"); | |||
| String version = BuildConfig.VERSION_NAME; | |||
| sdkVersion.setVersion(version); | |||
| sdkVersion.addPackage("sentry-core", version); | |||
| sdkVersion.addPackage("sentry-android-core", version); | |||
| sdkVersion.addPackage("maven:sentry-core", version); | |||
There was a problem hiding this comment.
so it's missing maven:sentry-android here, right? I remember asking it but not sure why
There was a problem hiding this comment.
good point, yes we are
There was a problem hiding this comment.
Well, we don't know though. It's missing only if it was installed. Which we don't know here, do we? How can we figure out if that package was added? Maybe meta-data merging?
There was a problem hiding this comment.
we could through reflection or adding something to manifest and check it on runtime or the backend side does the grouping and will know if android-core and android-ndk are there, but yes on the client side would be easier and less error-prone.
There was a problem hiding this comment.
agreed, will raise for that
No description provided.