Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

ANR report should have 'was active=yes' on the dashboard #299

Merged
merged 6 commits into from
Mar 26, 2020

Conversation

marandaneto
Copy link
Contributor

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

if ANR (was active)=yes on the dashboard.

馃挕 Motivation and Context

the thread that reports ANRs is ANRWatchDog, so right now it's gonna be always was active=no.
as we have an ExceptionMechanismException that takes a thread, main thread in the case, we can fix this easily.

to discuss: because of the change in this PR, the selected thread on the thread selector (dashboard) will be wrong, as the thread that reported the ANR is not the thread that has a stack trace.

馃挌 How did you test it?

tests already exist.

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

馃敭 Next steps

@codecov-io
Copy link

codecov-io commented Mar 13, 2020

Codecov Report

Merging #299 into master will increase coverage by 0.1%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #299     +/-   ##
===========================================
+ Coverage     58.86%   58.96%   +0.1%     
- Complexity      752      757      +5     
===========================================
  Files            86       86             
  Lines          3508     3519     +11     
  Branches        334      339      +5     
===========================================
+ Hits           2065     2075     +10     
  Misses         1294     1294             
- Partials        149      150      +1
Impacted Files Coverage 螖 Complexity 螖
.../main/java/io/sentry/core/SentryThreadFactory.java 90.9% <100%> (+0.9%) 12 <1> (+2) 猬嗭笍
...c/main/java/io/sentry/core/MainEventProcessor.java 76.08% <77.77%> (-0.23%) 12 <0> (+2)
...core/src/main/java/io/sentry/core/SentryEvent.java 69.91% <0%> (+0.81%) 54% <0%> (+1%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 19aaac5...64c2599. Read the comment docs.

@bruno-garcia bruno-garcia changed the title ANR report should have was active=yes on the dashboard ANR report should have 'was active=yes' on the dashboard Mar 23, 2020
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 possible improvement only

@marandaneto marandaneto marked this pull request as ready for review March 25, 2020 17:55
@marandaneto marandaneto merged commit 9c1c1a2 into master Mar 26, 2020
@marandaneto marandaneto deleted the fix/anr_was_active branch March 26, 2020 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants