Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

ndk events apply scoped data #322

Merged
merged 6 commits into from
Mar 25, 2020
Merged

ndk events apply scoped data #322

merged 6 commits into from
Mar 25, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Mar 25, 2020

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

ndk events apply scoped data.

馃挕 Motivation and Context

right now ndk events never apply scoped data, but it should.
fix #291

馃挌 How did you test it?

CI, tests

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

馃敭 Next steps

@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #322 into master will decrease coverage by 0.02%.
The diff coverage is 54.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #322      +/-   ##
============================================
- Coverage      58.8%   58.78%   -0.03%     
- Complexity      743      757      +14     
============================================
  Files            85       87       +2     
  Lines          3520     3530      +10     
  Branches        330      333       +3     
============================================
+ Hits           2070     2075       +5     
- Misses         1299     1302       +3     
- Partials        151      153       +2
Impacted Files Coverage 螖 Complexity 螖
...ntry/core/UncaughtExceptionHandlerIntegration.java 76.56% <酶> (酶) 9 <0> (酶) 猬囷笍
...c/main/java/io/sentry/core/MainEventProcessor.java 76.92% <100%> (+0.6%) 13 <3> (+3) 猬嗭笍
...ore/src/main/java/io/sentry/core/SentryClient.java 89.75% <100%> (+0.06%) 54 <6> (+3) 猬嗭笍
...c/main/java/io/sentry/core/DirectoryProcessor.java 77.77% <100%> (+1.77%) 6 <1> (酶) 猬囷笍
...re/src/main/java/io/sentry/core/SentryOptions.java 77.21% <100%> (+0.29%) 71 <0> (酶) 猬囷笍
...e/src/main/java/io/sentry/core/EnvelopeSender.java 65.88% <25%> (+3.26%) 12 <1> (酶) 猬囷笍
.../src/main/java/io/sentry/core/SendCachedEvent.java 54.54% <40%> (-4.78%) 6 <1> (酶)
.../java/io/sentry/core/hints/CachedEnvelopeHint.java 45.45% <45.45%> (酶) 4 <4> (?)
...java/io/sentry/core/hints/SendCachedEventHint.java 57.89% <57.89%> (酶) 4 <4> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1a47e98...475bcdb. Read the comment docs.

@marandaneto marandaneto marked this pull request as ready for review March 25, 2020 11:01
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few points for us to discuss

@marandaneto marandaneto merged commit 4b54ccd into master Mar 25, 2020
@marandaneto marandaneto deleted the fix/ndk-apply-scope-data branch March 25, 2020 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants