Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

logging envelopes path when possible instead of nullable id #331

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

logging envelopes path when possible instead of nullable id

💡 Motivation and Context

envelopes that don't have an id would log as null which is not useful at all.

💚 How did you test it?

running it.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Mar 31, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@9ed2c05). Click here to learn what that means.
The diff coverage is 41.17%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #331   +/-   ##
=========================================
  Coverage          ?   59.07%           
  Complexity        ?      766           
=========================================
  Files             ?       87           
  Lines             ?     3548           
  Branches          ?      344           
=========================================
  Hits              ?     2096           
  Misses            ?     1300           
  Partials          ?      152           
Impacted Files Coverage Δ Complexity Δ
...main/java/io/sentry/core/util/CollectionUtils.java 14.28% <14.28%> (ø) 1.00 <1.00> (?)
...c/main/java/io/sentry/core/cache/SessionCache.java 56.17% <25.00%> (ø) 23.00 <0.00> (?)
...n/java/io/sentry/core/transport/HttpTransport.java 67.78% <50.00%> (ø) 19.00 <0.00> (?)
...e/src/main/java/io/sentry/core/EnvelopeSender.java 67.46% <100.00%> (ø) 15.00 <7.00> (?)
...java/io/sentry/core/transport/AsyncConnection.java 66.43% <100.00%> (ø) 13.00 <0.00> (?)
...va/io/sentry/core/SentryEnvelopeHeaderAdapter.java 39.13% <0.00%> (ø) 3.00% <0.00%> (?%)
...ore/src/main/java/io/sentry/core/protocol/Gpu.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...n/java/io/sentry/core/hints/SessionUpdateHint.java 100.00% <0.00%> (ø) 1.00% <0.00%> (?%)
.../java/io/sentry/core/SentryEnvelopeItemHeader.java 81.81% <0.00%> (ø) 6.00% <0.00%> (?%)
.../src/main/java/io/sentry/core/cache/DiskCache.java 51.42% <0.00%> (ø) 12.00% <0.00%> (?%)
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed2c05...429fc3a. Read the comment docs.

@marandaneto marandaneto merged commit 0aa37ee into master Mar 31, 2020
@marandaneto marandaneto deleted the enha/better-logging-envelopes branch March 31, 2020 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants