This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
change integration order for cached outbox events #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=========================================
Coverage ? 58.96%
Complexity ? 760
=========================================
Files ? 87
Lines ? 3529
Branches ? 340
=========================================
Hits ? 2081
Misses ? 1298
Partials ? 150
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Apr 7, 2020
| // this should be executed after NdkIntegration because sentry-native move files on init. | ||
| // and we'd like to send them right away | ||
| options.addIntegration( | ||
| new SendCachedEventFireAndForgetIntegration( |
There was a problem hiding this comment.
One improvement is to pull this code into a its own class and adding here new Integration()
This would simplify this method a bit
There was a problem hiding this comment.
yep, could be done for the others too then, I just copy-pasta for now, but agreed, will raise other PR for all of them
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
change integration order for cached outbox events.
💡 Motivation and Context
as sentry-native move files around on init. and the outbox file observer now is inited after the NDK integration.
This integration also should be executed afterwards, so hard crashes will be in place and ready to be sent.
I've needed to make DirectoryProcessor public.
💚 How did you test it?
running and testing it.
📝 Checklist
🔮 Next steps